This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Update readme.md #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually, secret id's has a different look from what is currently in the README, which made me think first that you can pass names of environment variables into `secret` method instead of ID. Maybe it's me being stupid and rushing, but I think it would be better to have a less confusing description.
|
Thanks for the contribution :) I took a look at some of our code and we don't seem to need a prefix such as |
|
Hmm, yes, you're right, it is how it works on my current project, but it might be different on other projects. I've updated the PR to use named arguments instead, wdyt? |
|
Yep. that's perfect |
keirlawson
approved these changes
Dec 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually, secret id's has a different look from what is currently in the README, which made me think first that you can pass names of environment variables into
secretmethod instead of ID. Maybe it's me being stupid and rushing, but I think it would be better to have a less confusing description.