This repository has been archived by the owner on Sep 24, 2020. It is now read-only.
Improve list() handling #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddmler
reviewed
Sep 16, 2016
| $this->context->addVariable($symbol); | ||
| } | ||
| if ($var->name instanceof Node\Expr\Variable) { | ||
| // TODO what should we do here? |
There was a problem hiding this comment.
Just create the variable. It is the job of the analyzer to notice the usage of variable variables but the compiler should work with it.
The whole passSymbol method has to be refactored later into compiler and analyzer part (and the other pass methods in this class too)
| /** | ||
| * @return string | ||
| */ | ||
| public function arrayPropertyAccessVariable() |
There was a problem hiding this comment.
It would be best if we had one test for each case where it doesn't create a notice.
K-Phoen
force-pushed
the
better-list-handling
branch
from
21c2743
to
197b025
Compare
|
I updated the PR :) |
sergeyklay
reviewed
Sep 22, 2016
| // $array[] = … | ||
| if ($expr->var instanceof Expr\Variable) { | ||
| $result = $this->analyzeVar($expr->var, $context); | ||
| } else if ($expr->var instanceof Expr\PropertyFetch) { |
K-Phoen
force-pushed
the
better-list-handling
branch
2 times, most recently
from
36fdea5
to
3a05895
Compare
ddmler
approved these changes
Sep 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several (related) things:
list()handling: it previously emitted notices and failed to detect variables created using this contruct