Skip to content

Commit

Permalink
dts: fix DPDK git tarball cast bug
Browse files Browse the repository at this point in the history
When running DTS with a git revision specified the following error occurs:
$ ./main.py --revision HEAD
[...]
FileNotFoundError: [Errno 2] No such file or directory:
     'dts/<framework.utils.DPDKGitTarball object at 0x78f69e73a5c0>'

Fix by casting DPDKGitTarball to Path, in order to stringify it correctly.

Bugzilla ID: 1496
Fixes: a23f224 ("dts: constrain DPDK source argument")

Signed-off-by: Alex Chapman <alex.chapman@arm.com>
Reviewed-by: Jack Bond-Preston <jack.bond-preston@arm.com>
Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
Signed-off-by: 0-day Robot <robot@bytheb.org>
  • Loading branch information
Alex Chapman authored and ovsrobot committed Jul 19, 2024
1 parent fa8d2f7 commit 23d2585
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .mailmap
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ Aleksey Baulin <aleksey.baulin@gmail.com>
Aleksey Katargin <gureedo@gmail.com>
Ales Musil <amusil@redhat.com>
Alessio Igor Bogani <alessio.bogani@elettra.eu>
Alex Chapman <alex.chapman@arm.com>
Alexander Bechikov <asb.tyum@gmail.com>
Alexander Belyakov <abelyako@gmail.com>
Alexander Chernavin <achernavin@netgate.com>
Expand Down
2 changes: 1 addition & 1 deletion dts/framework/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ def get_settings() -> Settings:
args = parser.parse_args()

if args.dpdk_revision_id:
args.dpdk_tarball_path = DPDKGitTarball(args.dpdk_revision_id, args.output_dir)
args.dpdk_tarball_path = Path(DPDKGitTarball(args.dpdk_revision_id, args.output_dir))

args.test_suites = _process_test_suites(parser, args.test_suites)

Expand Down

0 comments on commit 23d2585

Please sign in to comment.