Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
app/testpmd: fix build on signed comparison
Build error: .../app/test-pmd/config.c: In function 'icmp_echo_config_setup': .../app/test-pmd/config.c:5159:30: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores) ^ All 'nb_txq', 'nb_fwd_ports' & 'nb_fwd_lcores' are unsigned variables, but the warning is related to the integer promotion rules of C: 'nb_txq' -> uint16_t, promoted to 'int' 'nb_fwd_ports' -> uint16_t, promoted to 'int' (nb_txq * nb_fwd_ports) -> result 'int' nb_fwd_lcores -> 'uint32_t' Ends up comparing 'int' vs 'uint32_t'. Fixing by adding the casting back which was initially part of the patch. Fixes: 2bf44dd ("app/testpmd: fix lcore ID restriction") Cc: stable@dpdk.org Reported-by: Raslan Darawsheh <rasland@nvidia.com> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com> Signed-off-by: 0-day Robot <robot@bytheb.org>
- Loading branch information