add public address handling to PNP #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fviale
commented
Apr 28, 2017
fviale
commented
- Added proactive.net.public_address setting. It allows to specify a hostname or ip address which can be used to contact the Remote Objects.
- This configuration is implemented in the PNP protocol only. In case this setting is configured, the PNP protocol creates urls like pnp://public_address@private_address:port
- To contact a Remote Object which contains a public address, the pnp protocol tries first to open a socket to the private address, and if the connection fails, it will create a socket to the public address.
- URIBuilder methods now have userInfo and query parameters
- Better escaping of urls in jmx FactoryName
- added a functional test TestPNPPublicAddress
- Added proactive.net.public_address setting. It allows to specify a hostname or ip address which can be used to contact the Remote Objects. - This configuration is implemented in the PNP protocol only. In case this setting is configured, the PNP protocol creates urls like pnp://public_address@private_address:port - To contact a Remote Object which contains a public address, the pnp protocol tries first to open a socket to the private address, and if the connection fails, it will create a socket to the public address. - URIBuilder methods now have userInfo and query parameters - Better escaping of urls in jmx FactoryName - added a functional test TestPNPPublicAddress
vinseon
suggested changes
Apr 28, 2017
| @@ -230,7 +231,7 @@ public InternalRemoteRemoteObject createRemoteObject(RemoteObject<?> remoteObjec | |||
| } | |||
|
|
|||
| URI uri = new URI(this.getProtocolId(), | |||
| null, | |||
| ProActiveInet.getPublicAddress(), | |||
There was a problem hiding this comment.
I think we should explicitly indicate here that the public IP address is intentionally given through the "UserInfo" field and explain why (namespace issue using the 'query' field ?).
|
Retest this please |
paraita
approved these changes
May 2, 2017
- added a comment which describes the use of userinfo in the pnp uri - use override annotation
vinseon
approved these changes
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.