Improve SchedulerClient compliance with Scheduler API #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fviale
commented
Nov 27, 2016
fviale
commented
- improve the handling of job and task results handling, to allow transparent navigation (job to task, logs, etc). Added correct dozer mappings for job and task results
- improve the handling of job info and corrected the metrics which were broken in both Java and Rest apis
- implemented a few previously unsupported methods in SchedulerClient class
- better handling of the task logs and exception in Task result
- Added a test in SchedulerClientTest to test a few accesses to the scheduler api, mostly job result but also job state, job info
synchronize fork
synchronize fork
synchronize fork
- improve the handling of job and task results handling, to allow transparent navigation (job to task, logs, etc). Added correct dozer mappings for job and task results - improve the handling of job info and corrected the metrics which were broken in both Java and Rest apis - implemented a few previously unsupported methods in SchedulerClient class - better handling of the task logs and exception in Task result - Added a test in SchedulerClientTest to test a few accesses to the scheduler api, mostly job result but also job state, job info
- fixing unit tests
…into ow2-proactive-master
marcocast
reviewed
Dec 30, 2016
| throw new UnsupportedOperationException(); | ||
| Map<String, TaskStateData> taskStateMap = jobStateData.getTasks(); | ||
| Map<TaskId, TaskState> hmTasks = new HashMap<>(); | ||
| for (TaskStateData ts : taskStateMap.values()) { |
There was a problem hiding this comment.
can you call ts "taskStateData" ?
marcocast
reviewed
Dec 30, 2016
| @@ -68,7 +70,13 @@ private void copyGenericInformation(JobStateData jobStateData) { | |||
|
|
|||
| @Override | |||
| public Map<TaskId, TaskState> getHMTasks() { | |||
| throw new UnsupportedOperationException(); | |||
| Map<String, TaskStateData> taskStateMap = jobStateData.getTasks(); | |||
| Map<TaskId, TaskState> hmTasks = new HashMap<>(); | |||
There was a problem hiding this comment.
can you give a better name to hmTasks ?
marcocast
approved these changes
Dec 30, 2016
|
SonarQube analysis reported 5 issues
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.