Skip to content

Commit

Permalink
refactor: remove eslint-plugin-node (antfu#162)
Browse files Browse the repository at this point in the history
  • Loading branch information
zanminkian committed Apr 4, 2023
1 parent 7a5daf6 commit 3f13db7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 34 deletions.
7 changes: 3 additions & 4 deletions packages/eslint-config-basic/index.js
Expand Up @@ -49,7 +49,6 @@ module.exports = {
'antfu',
'no-only-tests',
'unused-imports',
'node',
],
settings: {
'import/resolver': {
Expand Down Expand Up @@ -317,8 +316,9 @@ module.exports = {
'max-statements-per-line': ['error', { max: 1 }],

// node
// 'node/prefer-global/process': ['error', 'never'], // Not sure if we need it as we are using `process.env.NODE_ENV` a lot in front-end.
'node/prefer-global/buffer': ['error', 'never'],
// 'n/prefer-global/process': ['error', 'never'], // Not sure if we need it as we are using `process.env.NODE_ENV` a lot in front-end.
'n/prefer-global/buffer': ['error', 'never'],
'n/no-callback-literal': 'off',

// unicorns
// Pass error message when throwing errors
Expand Down Expand Up @@ -351,7 +351,6 @@ module.exports = {
'import/no-named-as-default-member': 'off',
'import/no-named-as-default': 'off',
'import/namespace': 'off',
'n/no-callback-literal': 'off',

'sort-imports': [
'error',
Expand Down
1 change: 0 additions & 1 deletion packages/eslint-config-basic/package.json
Expand Up @@ -27,7 +27,6 @@
"eslint-plugin-markdown": "^3.0.0",
"eslint-plugin-n": "^15.7.0",
"eslint-plugin-no-only-tests": "^3.1.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^6.1.1",
"eslint-plugin-unicorn": "^46.0.0",
"eslint-plugin-unused-imports": "^2.0.0",
Expand Down
29 changes: 0 additions & 29 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3f13db7

Please sign in to comment.