Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow connecting to non-standard ports #33

Open
c-garcia opened this issue Nov 18, 2015 · 3 comments
Open

Allow connecting to non-standard ports #33

c-garcia opened this issue Nov 18, 2015 · 3 comments

Comments

@c-garcia
Copy link
Contributor

Hi,

It would be useful to be able to specify the server port when creating the store. As a nice byproduct, this will make possible to create integration tests with Greenmail.

How to maintain the store function as backwards compatible is another story. Having it as multi-arity makes this a small challenge. As a suggestion, to specify the port, the server parameter could be passed as a vector [host port]. If passed as a String, the default ones would be used.

Thanks and regards.

c-garcia added a commit to c-garcia/clojure-mail that referenced this issue Nov 18, 2015
As per the issue owainlewis#33, store now supports the target port to be
passed as a parameter.
Also greenmail has been added as a dependency and some
integration testing has been added.
@shisoft
Copy link

shisoft commented Nov 19, 2015

I am also wondering if there is any way to use other port number since there is already a parameter for protocol.

@c-garcia
Copy link
Contributor Author

Closed despite of this is not released to clojars. I don't know how you want to handle this. If I need to re-open, just let me know please.

@owainlewis
Copy link
Owner

TODO: New release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants