Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand, improve, consolidate dockertests #136

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

cerrussell
Copy link
Collaborator

@cerrussell cerrussell commented Oct 1, 2023

  • Expands matrix to run everything on all OSes,
  • Adds running pytest tests for all os x python-version
  • Addresses codec issue in ms_test on Windows,
  • Combines ms_test and version_tests2 for efficiency (leaves version_tests separate due to multiple python versions in matrix).
  • Adds improved artifacts names so that artifacts aren't written over due to using same artifact name for all runs in matrix

Successful run.

We may want to clarify what is being tested by renaming this workflow and certain steps in the future since Docker and containers don't appear to be involved.

Closes #135

… OSes, combine version_tests2 and ms_test

Signed-off-by: Caroline Russell <caroline@appthreat.dev>
@cerrussell cerrussell requested a review from prabhu October 1, 2023 04:14
Copy link
Member

@prabhu prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, superb!

@cerrussell cerrussell merged commit 400bfed into owasp-dep-scan:master Oct 1, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving workflow tests in dockertests.yml
2 participants