Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 3.12 tests #137

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Adds 3.12 tests #137

merged 2 commits into from
Oct 10, 2023

Conversation

prabhu
Copy link
Member

@prabhu prabhu commented Oct 3, 2023

  • setuptools is no longer installed in venv in Python 3.12. Is there a different way to rewrite the get_version method to avoid this dependency?

https://github.com/owasp-dep-scan/dep-scan/blob/master/depscan/lib/utils.py#L376

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu requested a review from cerrussell October 4, 2023 17:57
@prabhu prabhu merged commit 261e42e into master Oct 10, 2023
71 checks passed
@prabhu prabhu deleted the feature/py312 branch October 10, 2023 13:05
saketjajoo pushed a commit that referenced this pull request Oct 16, 2023
* Adds 3.12 tests

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>

* Adds 3.12 tests

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>

---------

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
cerrussell pushed a commit to timmyteo/dep-scan that referenced this pull request Oct 16, 2023
* Adds 3.12 tests

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>

* Adds 3.12 tests

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>

---------

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
cerrussell added a commit that referenced this pull request Oct 25, 2023
* Adds github client and PAT inspection

* CI, Python version fixes

Consolidate exceptions

Signed-off-by: Caroline Russell <caroline@appthreat.dev>

Output exception

Signed-off-by: Caroline Russell <caroline@appthreat.dev>

Handle GitHubException

Signed-off-by: Caroline Russell <caroline@appthreat.dev>

Don't fail-fast version_tests2

Signed-off-by: Caroline Russell <caroline@appthreat.dev>

Fix type hints, unnecessary test runs

Signed-off-by: Caroline Russell <caroline@appthreat.dev>

* Addressing PR concerns

* Adds 3.12 tests (#137)

* Adds 3.12 tests

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>

* Adds 3.12 tests

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>

---------

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>

* Update to work with GitHub Actions tokens

---------

Signed-off-by: Caroline Russell <caroline@appthreat.dev>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Co-authored-by: Tim Messing <141575989+timmyteo@users.noreply.github.com>
Co-authored-by: Caroline Russell <caroline@appthreat.dev>
Co-authored-by: prabhu <prabhu@appthreat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants