Accept the path to a bom file (in the /scan endpoint) while running dep-scan in the server mode #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhu
reviewed
Nov 27, 2023
prabhu
reviewed
Nov 27, 2023
saketjajoo
force-pushed
the
feature/scan_bomfile_server
branch
from
2fe8d0e
to
449ee7e
Compare
prabhu
reviewed
Nov 29, 2023
prabhu
reviewed
Nov 29, 2023
prabhu
approved these changes
Nov 29, 2023
prabhu
reviewed
Nov 30, 2023
saketjajoo
force-pushed
the
feature/scan_bomfile_server
branch
from
a0da297
to
0846e17
Compare
prabhu
reviewed
Dec 2, 2023
prabhu
reviewed
Dec 2, 2023
|
|
||
| if uploaded_bom_file.get('file', None) is not None: | ||
| bom_file = uploaded_bom_file['file'] | ||
| bom_file_content = bom_file.read().decode('utf-8') |
There was a problem hiding this comment.
At this point the uploaded file could be of any extension including videos and binaries. Is there another eay to configure quart to only accept specific mimetypes?
There was a problem hiding this comment.
By default, the mime-type of a file is interpreted as a binary blob of data, and the mime-type is set to application/octet-stream. Hence, filtering (or accepting) the input files based on their mime-types is difficult.
Ref: https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types
saketjajoo
force-pushed
the
feature/scan_bomfile_server
branch
from
0846e17
to
5fa0a1a
Compare
prabhu
approved these changes
Dec 4, 2023
|
I've created a PR (#172) to update the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue: #157