Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the scope of npm alias to search for vendor with the name npm #241

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

prabhu
Copy link
Member

@prabhu prabhu commented Feb 11, 2024

For the attached sbom, we get results for all versions of axios from both npm and osv. Previously, osv results were getting lost due to the use of npm as the vendor name.

Dependency Scan Results (JS)
╔═══════════════════════════════════════════════════════════════════╤═══════════════════════════════════╤═══════════════════╤══════════════╤═════════╗
║ Dependency Tree                                                   │ Insights                          │ Fix Version       │ Severity     │   Score ║
╟───────────────────────────────────────────────────────────────────┼───────────────────────────────────┼───────────────────┼──────────────┼─────────╢
║ snowflake-sdk@1.9.0                                               │ 📓 Indirect dependency            │ 1.6.0             │ MEDIUM       │     6.5 ║
║ └── axios@1.5.1 ⬅ CVE-2023-45857                                  │                                   │                   │              │         ║
╟───────────────────────────────────────────────────────────────────┼───────────────────────────────────┼───────────────────┼──────────────┼─────────╢
║ axios@0.21.4                                                      │ 📓 Indirect dependency            │ 1.15.4            │ MEDIUM       │     6.1 ║
║ └── follow-redirects@1.15.2 ⬅ CVE-2023-26159                      │                                   │                   │              │         ║
╟───────────────────────────────────────────────────────────────────┼───────────────────────────────────┼───────────────────┼──────────────┼─────────╢
║ webhook@6.1.0                                                     │ 📓 Indirect dependency            │ 1.6.0             │ MEDIUM       │     6.5 ║
║ └── axios@0.21.4 ⬅ CVE-2023-45857                                 │                                   │                   │              │         ║
╟───────────────────────────────────────────────────────────────────┼───────────────────────────────────┼───────────────────┼──────────────┼─────────╢
║ issue-dup-versions@1.0.0                                          │ 📓 Indirect dependency            │ 1.6.0             │ MEDIUM       │     6.5 ║
║ └── axios@0.27.2 ⬅ CVE-2023-45857                                 │                                   │                   │              │         ║
╟───────────────────────────────────────────────────────────────────┼───────────────────────────────────┼───────────────────┼──────────────┼─────────╢
║ parse-bmfont-xml@1.1.4                                            │ 📓 Indirect dependency            │ 0.5.0             │ MEDIUM       │     5.3 ║
║ └── xml2js@0.4.23 ⬅ CVE-2023-0842                                 │                                   │                   │              │         ║
╚═══════════════════════════════════════════════════════════════════╧═══════════════════════════════════╧═══════════════════╧══════════════╧═════════╝
╭────────────── Recommendation ───────────────╮
│ ✅ No package requires immediate attention. │
╰─────────────────────────────────────────────╯

sbom-js.json.txt

@heubeck, could you kindly test if this results in false positives for you since this is a fix requested by another enterprise client?

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu requested a review from heubeck February 11, 2024 17:35
@prabhu prabhu merged commit d78b70e into release/5.x Feb 11, 2024
46 of 52 checks passed
@prabhu prabhu deleted the fix/npm-duplicate-filter branch February 11, 2024 17:56
@heubeck
Copy link
Collaborator

heubeck commented Feb 12, 2024

cannot say ad-hoc, need to observe. thx for hinting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants