Bugfix: missing string terminator while mounting the charset (nginx) #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The charset in headers is mounted using ngx_snprintf which does not place the string terminator. This patch adds the terminator at the end of the string. The size was correctly allocated, just missing the terminator. This bug was report at: - https://www.modsecurity.org/tracker/browse/MODSEC-420 - owasp-modsecurity#142 Both reports cames with patch, first by Veli Pekka Jutila and second by wellumies.
rcbarnett-zz
pushed a commit
that referenced
this pull request
Oct 1, 2013
…erminator Bugfix: missing string terminator while mounting the charset (nginx)
ahuango
added a commit
to ahuango/ModSecurity
that referenced
this pull request
Dec 12, 2013
Pull request owasp-modsecurity#148 by zimmerle doesn't fix the problem. '\0' in format string won't be processed by "ngx_vslprintf". When the garbage character is '\n' or '\r', http response is cracked and browsers may go crashing.
zimmerle
pushed a commit
that referenced
this pull request
Dec 19, 2013
Pull request #148 by zimmerle doesn't fix the problem. '\0' in format string won't be processed by "ngx_vslprintf". When the garbage character is '\n' or '\r', http response is cracked and browsers may go crashing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The charset in headers is mounted using ngx_snprintf which
does not place the string terminator. This patch adds the
terminator at the end of the string. The size was correctly
allocated, just missing the terminator.
This bug was report at:
Both reports comes with patch, first by Veli Pekka Jutila and
second by wellumies.