Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define m_secmarker_skipped as an integer type #1737

Conversation

p0pr0ck5
Copy link
Contributor

There's no reason to treat this this as a double, since it represents a human-readable data value that is only meaningful as an integer. In doing so we write cleaner audit logs and save a small amount of space.

There's no reason to treat this this as a double, since it
represents a human-readable data value that is only meaningful
as an integer. In doing so we write cleaner audit logs and save
a small amount of space.
@zimmerle zimmerle self-assigned this Apr 24, 2018
@zimmerle zimmerle added the 3.x Related to ModSecurity version 3.x label Apr 24, 2018
@zimmerle zimmerle self-requested a review April 24, 2018 01:58
zimmerle pushed a commit that referenced this pull request Apr 24, 2018
@zimmerle
Copy link
Contributor

Hi @p0pr0ck5,

Thanks for the patch. Indeed no need do show the decimal part to the user. However, I am afraid this patch will not write a cleaner audit logs or save any considerable amount of space as this specific variable is only used in the debug logs.

As a matter of fact, as of 6f92c89 this variable is complete disable if ModSecurity is compiled without the debug logs.

m_secmarker_skipped Life Cycle

As you can see, all those references are related to the debug logs. Let me know if you have any further question.

@zimmerle zimmerle closed this Apr 24, 2018
@p0pr0ck5
Copy link
Contributor Author

Whups, I had meant to say debug logs, not audit logs. My apologies.

@p0pr0ck5 p0pr0ck5 deleted the v3/secmarker-skipped-int branch April 24, 2018 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Related to ModSecurity version 3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants