Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: function m.setvar not work in lua script #1859

Closed
wants to merge 2 commits into from
Closed

fix: function m.setvar not work in lua script #1859

wants to merge 2 commits into from

Conversation

nowaits
Copy link
Contributor

@nowaits nowaits commented Jul 30, 2018

No description provided.

@victorhora
Copy link
Contributor

fix: centos compile error (9f9a59d)

There's a PR to address this issue here #1855

@victorhora victorhora added RIP - libmodsecurity 3.x Related to ModSecurity version 3.x labels Jul 31, 2018
@DenysFrasinich
Copy link

Hello!

I also had problem with "m.setvar" in lua scripts. But after i rebuild v3/master with patch from 86c12c3 commit by @nowaits it works properly.

@victorhora victorhora self-requested a review September 15, 2018 13:26
@victorhora victorhora added this to the v3.0.3 milestone Sep 15, 2018
@victorhora victorhora self-assigned this Sep 15, 2018
victorhora added a commit that referenced this pull request Sep 19, 2018
@victorhora
CHANGES: Adds info about: #1859
0d53111
@victorhora
Copy link
Contributor

Hey @nowaits, thanks for your contribution :)

Your commit has been accepted as of 45cdb0e

I added 6f458b5 to also cover for the USER collection, and test cases for all of them here 5aa79c1

Thanks :)

@victorhora victorhora closed this Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorhora victorhora Awaiting requested review from victorhora

Assignees

@victorhora victorhora

Labels
3.x Related to ModSecurity version 3.x bug It is a confirmed bug libmodsec - missing features RIP - libmodsecurity
Projects
None yet
Milestone
v3.0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nowaits @victorhora @DenysFrasinich