Add correct C function prototypes for msc_init and msc_create_rule_set #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorhora
reviewed
Oct 13, 2018
There was a problem hiding this comment.
Thanks for the contribution @steven-j-wojcik :)
It took me some time to figure out why I was getting cc1: error: -Werror=strict-prototype: no option -Wstrict-prototypeerror. The option is named strict-prototypes and not strict-prototype.
In file included from multi.c:16:0:
../../headers/modsecurity/modsecurity.h:320:1: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
ModSecurity *msc_init();
^
In file included from multi.c:18:0:
../../headers/modsecurity/rules.h:99:1: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
Rules *msc_create_rules_set();
^
cc1: some warnings being treated as errors
Pull request fixes the issue. Merging ;)
victorhora
added a commit
that referenced
this pull request
Oct 13, 2018
|
Merged at 004047e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C function prototypes require a void parameter otherwise the error:
function declaration isn't a prototypewill be thrown in some compilers with-Werror=strict-prototypeset.