Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isolated PCRE match limits as a layer of ReDoS defense #2736

Merged
merged 7 commits into from
May 9, 2023
Merged

Add isolated PCRE match limits as a layer of ReDoS defense #2736

merged 7 commits into from
May 9, 2023

Commits on Apr 11, 2023

  1. Update Regex util to support match limits 

    If the rx or rxGlobal operator encounters a regex error,
the RX_ERROR and RX_ERROR_RULE_ID variables are set.
RX_ERROR contains a simple error code which can be either
OTHER or MATCH_LIMIT. RX_ERROR_RULE_ID unsurprisingly
contains the ID of the rule associated with the error.
More than one rule may encounter regex errors,
but only the first error is reflected in these variables.
    @brandonpayton
    brandonpayton committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8c269d3 View commit details
    Browse the repository at this point in the history

  2. Fix some style issues in regex util header

    @brandonpayton
    brandonpayton committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8c4b7c1 View commit details
    Browse the repository at this point in the history

  3. Switch to simpler PCRE error flags

    @brandonpayton
    brandonpayton committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0c42ee2 View commit details
    Browse the repository at this point in the history

  4. Respond to code review feedback

    @brandonpayton
    brandonpayton committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    f3d8198 View commit details
    Browse the repository at this point in the history

  5. Give PCRE error vars initial value

    @brandonpayton
    brandonpayton committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    23a0e26 View commit details
    Browse the repository at this point in the history

  6. Move var into conditional block where used

    @brandonpayton
    brandonpayton committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    6f1bd27 View commit details
    Browse the repository at this point in the history

  7. Add PCRE error tests for rx operator

    @brandonpayton
    brandonpayton committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d875738 View commit details
    Browse the repository at this point in the history