Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't directly use the .libs directory #2980

Closed
wants to merge 1 commit into from

Conversation

orbea
Copy link

@orbea orbea commented Sep 2, 2023

The build system should not directly use the .libs directory which is intended for internal use by the libtool implementation. Additionally when linking with internal a library the .la file should be used as this provides all the information required by the libtool implementation.

When using Slibtool instead of GNU Libtool the build fails because Slibtool is more strict about this and fails to find the required files to link with.

Gentoo Bug: https://bugs.gentoo.org/913484

orbea added a commit to orbea/gentoo that referenced this pull request Sep 5, 2023
orbea added a commit to orbea/gentoo that referenced this pull request Sep 6, 2023
orbea added a commit to orbea/gentoo that referenced this pull request Sep 6, 2023
@orbea
Copy link
Author

orbea commented Dec 13, 2023

@martinhsv Can you please review this PR? It should be straight forward.

gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Jan 5, 2024
Closes: https://bugs.gentoo.org/913484
Upstream-PR: owasp-modsecurity/ModSecurity#2980
Signed-off-by: orbea <orbea@riseup.net>
Closes: #32631
Signed-off-by: Sam James <sam@gentoo.org>
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@airween airween added the 3.x Related to ModSecurity version 3.x label Feb 27, 2024
@airween airween self-assigned this Feb 27, 2024
@airween
Copy link
Member

airween commented Feb 27, 2024

Hi @orbea,

thanks for sending for your first contribution!

Unfortunately for some reason, the regression tests didn't run when you sent this PR. Although the PR does not affect relevant parts, could you sent it again or add some minimal modification (fetch the newer version of the source tree), and commit that? Let me see that the CI starts now.

(I can't find even find your PR here).

Thanks!

The build system should not directly use the .libs directory which is
intended for internal use by the libtool implementation. Additionally
when linking with internal a library the .la file should be used as this
provides all the information required by the libtool implementation.

When using Slibtool instead of GNU Libtool the build fails because
Slibtool is more strict about this and fails to find the required files
to link with.

Gentoo Bug: https://bugs.gentoo.org/913484
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@orbea
Copy link
Author

orbea commented Feb 27, 2024

@airween I tried to rebase and force push the branch, but it failed on account of code duplication. So tried to make PR #3097, but it needs maintainer approval.

@airween
Copy link
Member

airween commented Mar 29, 2024

@orbea: would you mind to create a new PR from a fresh cloned repository?

I'm going to close this one - thanks for your effort!

@airween airween closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Related to ModSecurity version 3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants