-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: don't directly use the .libs directory #2980
Conversation
Closes: https://bugs.gentoo.org/913484 Upstream-PR: owasp-modsecurity/ModSecurity#2980 Signed-off-by: orbea <orbea@riseup.net>
Closes: https://bugs.gentoo.org/913484 Upstream-PR: owasp-modsecurity/ModSecurity#2980 Signed-off-by: orbea <orbea@riseup.net>
Closes: https://bugs.gentoo.org/913484 Upstream-PR: owasp-modsecurity/ModSecurity#2980 Signed-off-by: orbea <orbea@riseup.net>
@martinhsv Can you please review this PR? It should be straight forward. |
Closes: https://bugs.gentoo.org/913484 Upstream-PR: owasp-modsecurity/ModSecurity#2980 Signed-off-by: orbea <orbea@riseup.net> Closes: #32631 Signed-off-by: Sam James <sam@gentoo.org>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Hi @orbea, thanks for sending for your first contribution! Unfortunately for some reason, the regression tests didn't run when you sent this PR. Although the PR does not affect relevant parts, could you sent it again or add some minimal modification (fetch the newer version of the source tree), and commit that? Let me see that the CI starts now. (I can't find even find your PR here). Thanks! |
The build system should not directly use the .libs directory which is intended for internal use by the libtool implementation. Additionally when linking with internal a library the .la file should be used as this provides all the information required by the libtool implementation. When using Slibtool instead of GNU Libtool the build fails because Slibtool is more strict about this and fails to find the required files to link with. Gentoo Bug: https://bugs.gentoo.org/913484
Quality Gate failedFailed conditions |
@orbea: would you mind to create a new PR from a fresh cloned repository? I'm going to close this one - thanks for your effort! |
The build system should not directly use the
.libs
directory which is intended for internal use by the libtool implementation. Additionally when linking with internal a library the.la
file should be used as this provides all the information required by the libtool implementation.When using Slibtool instead of GNU Libtool the build fails because Slibtool is more strict about this and fails to find the required files to link with.
Gentoo Bug: https://bugs.gentoo.org/913484