Revert merge request #139 #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well reported on the bug report #153, there was a side effect by applying this patch. This side effect was caused due to a race condition while cleaning and creating a new instance of the ModSecurity standalone implementation. Sometimes the second instance was freed instead of the first. Leaving the resource utilized by the first instance occupied, however, in a inconsistent way, leading ModSecurity to fail.
The first reported bug (#137) which this patch was made to fix, is not so critical in the sense that it does not leave the ModSecurity to fail straight. Having said that I am now reverting this fix, opening again the issue #137.