-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM Shrinkwrap? #23
Comments
Hey Andri, I was not aware of I would prefer to treat dev dependencies in the same way, so running shrinkwrap with |
I have a feeling running it with |
Good point. One of the reasons I committed modules initially was to have consistent dev environment, especially grunt's version. So I think the little overhead of deploying dev dependencies to prod should be fine. Would you like to work on this change? |
Worth noting, |
@jksdua Thanks for the comment. While package.json can control exact versions of packages explicitly specified in package.json, it can't control recursive dependencies of external packages. Shrinkwrap allows us to do that w/o needing to check-in these dependencies. Please feel free to assign this issue to yourself if you want to assist on incorporating shrinkwrap. |
@ckarande Sounds good. I am thinking the following:
|
@jksdua Perfect! Thanks. Feel free to send a pull request once ready. |
We will not use shrinkwrap, as having npm dependencies added in code makes it easier it deploy on BWA VM instances w/o network connectivity |
Hey,
Have you thought about just using
npm shrinkwrap
instead of committing all modules to version control?The text was updated successfully, but these errors were encountered: