[FIX] Issue 418 - Audit presentation #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the Tags feature (introduced in v5.0.0), when using the
getMetadata()method in thetrans()and@lang()helpers, which would cause an error (see #418).The fix does cause a minor breaking change, although it's quite straightforward to mitigate (in case you're using the tag values).
Previous calls to
$audit->tags, which would return an array (['foo', 'bar',]or[]), now return the original string value (foo,barornull) as stored in the database.To get the tags as an
array, like in versions v5.0.0 up to v6.1.0, you should now use thegetTags()method instead:$audit->getTags()