-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 5.8 support #489
Laravel 5.8 support #489
Conversation
Unfortunately it's not this simple to support Laravel 5.8. Have a look at the Upgrade Guide. There are a few things that have been deprecated that this package still supports. For example, this package still uses the deprecated string and array helpers, the All of the packages that this package requires also need to support 5.8, but |
@delenamalan thanks, I fixed all the issues you mentioned |
orchestra/database 3.8 hasn't been released yet, but hopefully will be soon 👍 |
Why does it matter for a require-dev to have stable deps, none of the user using the project will require it, the travis configuration doesn't run on any of the previous Laravel build except latest stable and orchestra/database is no longer required since orchestra/testbench 3.6 |
composer.json
Outdated
"orchestra/testbench": "^3.5", | ||
"orchestra/database": "^3.5" | ||
"orchestra/testbench": "^3.8", | ||
"orchestra/database": "^3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
orchestra/testbench
3.8
doesn't needs orchestra/database
, you can simply remove the deps and service provider in your tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crynobone thanks for your advices, I removed what you said :)
I fixed composer deps and unit test |
Thank you for your contribution @squiaios |
with pleasure @anteriovieira |
Are there any changes required when going from 8.0.0 to 9.0.0? Either way, it should probably be mentioned here: http://www.laravel-auditing.com/docs/9.0/upgrading |
No description provided.