Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.8 support #489

Merged
merged 2 commits into from
Mar 3, 2019
Merged

Laravel 5.8 support #489

merged 2 commits into from
Mar 3, 2019

Conversation

squiaios
Copy link
Contributor

No description provided.

@delenamalan
Copy link

Unfortunately it's not this simple to support Laravel 5.8. Have a look at the Upgrade Guide. There are a few things that have been deprecated that this package still supports. For example, this package still uses the deprecated string and array helpers, the defer property of service providers and the deprecated fire method of the Illuminate/Events/Dispatcher class.

All of the packages that this package requires also need to support 5.8, but orchestral/database doesn't yet. 😞

@squiaios
Copy link
Contributor Author

squiaios commented Feb 27, 2019

@delenamalan thanks, I fixed all the issues you mentioned

@delenamalan
Copy link

delenamalan commented Feb 27, 2019

orchestra/database 3.8 hasn't been released yet, but hopefully will be soon 👍

@crynobone
Copy link

crynobone commented Feb 27, 2019

Why does it matter for a require-dev to have stable deps, none of the user using the project will require it, the travis configuration doesn't run on any of the previous Laravel build except latest stable and orchestra/database is no longer required since orchestra/testbench 3.6

composer.json Outdated
"orchestra/testbench": "^3.5",
"orchestra/database": "^3.5"
"orchestra/testbench": "^3.8",
"orchestra/database": "^3.8"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orchestra/testbench 3.8 doesn't needs orchestra/database, you can simply remove the deps and service provider in your tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crynobone thanks for your advices, I removed what you said :)

@squiaios
Copy link
Contributor Author

I fixed composer deps and unit test

@anteriovieira anteriovieira added v9 and removed V8 labels Mar 2, 2019
@anteriovieira anteriovieira merged commit eff1fe2 into owen-it:master Mar 3, 2019
@CraigBSM CraigBSM mentioned this pull request Mar 4, 2019
@anteriovieira
Copy link
Member

Thank you for your contribution @squiaios

@squiaios squiaios deleted the patch-1 branch March 15, 2019 13:46
@squiaios
Copy link
Contributor Author

Thank you for your contribution @squiaios

with pleasure @anteriovieira

@vpillinger
Copy link

Are there any changes required when going from 8.0.0 to 9.0.0?

Either way, it should probably be mentioned here: http://www.laravel-auditing.com/docs/9.0/upgrading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants