Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UrlResolver resolve the proper command line used instead of "console" #851

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

tigitz
Copy link
Contributor

@tigitz tigitz commented Aug 24, 2023

Hello,

I've had ambiguous audits in the past where we couldn't determinate from which of our scheduled command these modifications were coming from because everything is "console", so the debugging experience were not ideal.

To improve the situation I implemented a custom way to retrieve the proper command line used while generating the audit, this works great for us.

image

So I decided to contribute it.

Note: Since the url metadata is now non deterministic in tests because of various possible ways to run the tests (arguments, options, paths, etc.), I've decided to expose the command line resolving logic to make use of it in tests that are not meant to test this feature specifically.
And then introduce a test that is meant to run with a specific command line and thus expect a deterministic output. This one is actually testing the logic.

@MortenDHansen
Copy link
Contributor

I like that idea!

What say you @erikn69 / @anteriovieira ?

@erikn69
Copy link
Contributor

erikn69 commented Aug 25, 2023

I think it's a great idea, we would have more detailed information where the audit comes from

@tigitz
Copy link
Contributor Author

tigitz commented Sep 4, 2023

Great to see everyone on board with the feature 🙂 . Should I expect it to be merged for the next release ? Thanks

@MortenDHansen MortenDHansen merged commit a80dcb9 into owen-it:master Oct 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants