Replaces deprecated fields, field_values and field_groups associations #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by the custom_fields, custom_field_values and custom_field_groups where possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @owen2345,
Association fields, field_values and field_groups have a comment marking them as deprecated and to use the custom_fields, custom_field_values and custom_field_groups instead.
This pull request tries to do that. With it in place, it allows us to improve performance in situations like when we use try to use different custom fields for a post or multiple posts
Nevertheless, there are still places where the old association is still being used because it failed the tests.
I'm not sure if nothing else will break with this change.
Thank you,
Filipe