Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #13 #14

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Fixes #13 #14

merged 1 commit into from
Jun 28, 2021

Conversation

veselov
Copy link
Contributor

@veselov veselov commented Jun 27, 2021 •
edited
Loading

Fixes #13.
I don't have any Ruby experience, so that's the best I could come up with.

@owenh000 owenh000 merged commit 6718d12 into owenh000:master Jun 28, 2021
owenh000 added a commit that referenced this pull request Jun 28, 2021
@owenh000
Merge 'veselov-13': support block table col style
9cf003c 
Add support for AsciiDoc "a" operator block-level table styling, which
supports block elements in a table cell by internally nesting a
separate document.

Thanks to @veselov for contributing this fix.

Closes both
<#13> and
<#1>.

See <#14>.
@owenh000
Copy link
Owner

Hi @veselov,

I don't have any Ruby experience, so that's the best I could come up with.

Well now you do! And thanks for the fix; it looks great. I already merged it.

The only significant change I made was putting the multipage-level attr in the test document header instead, like the other tests. This avoids adding a development dependency for YAML parsing. If you know a compelling reason for using separate YAML files for attributes in the tests, feel free to open another issue where we can discuss it.

@owenh000 owenh000 mentioned this pull request Jun 28, 2021
Closed
@veselov
Copy link
Contributor Author

veselov commented Jun 28, 2021

Thank you!

The only significant change I made was putting the multipage-level attr in the test document header instead, like the other tests

Ah, I'm quite new to AsciiDoc as well, it didn't strike me that this would have the exact same effect 🤦‍♂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lists in tables cause NPE
2 participants
@veselov @owenh000