add file support without $schema for sarif vscode extension and change default permission for out sarif file #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebziz
changed the title
owenrumney
reviewed
Jan 24, 2022
v2/sarif/sarif.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| func New(version Version, printSchema... bool) (*Report, error) { |
There was a problem hiding this comment.
I'm happy with this in principle and it test okay - I'd prefer this to be includeSchema as I don't think printSchema gets across the intent.
Otherwise I'm happy
There was a problem hiding this comment.
I agree and replaced it in the next commit
owenrumney
approved these changes
Jan 25, 2022
|
@zhizhchienko0162 - released as 2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/sarif-vscode-extension#169