Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to latest final 2.1.0 #69

Closed
wants to merge 2 commits into from
Closed

chore: update to latest final 2.1.0 #69

wants to merge 2 commits into from

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Sep 26, 2023

πŸ“‘ Description

It looks like the 2.1.0 schema was finalized and exists here.

Documents generated with go-sarif using the old schema rtm in the schema field will fail Microsoft's schema validation found here:
https://sarifweb.azurewebsites.net/

The diff between rtm and main is immaterial and only consists of description updates.

This change should make the schema field of the generated document valid with upstream tooling =)

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@spiffcs
Copy link
Contributor Author

spiffcs commented Sep 26, 2023

Also happy to update the URL to any other one you might deem more appropriate =)

@spiffcs
Copy link
Contributor Author

spiffcs commented Sep 28, 2023

@owenrumney Let me know if there is anything else you need for this PR - happy to make any changes or updates!

@owenrumney
Copy link
Owner

Thanks for this @spiffcs - I wonder if we should use https://docs.oasis-open.org/sarif/sarif/v2.1.0/errata01/os/schemas/sarif-schema-2.1.0.json for the schema as this appears to be the up-to-date one direct

owenrumney pushed a commit that referenced this pull request Oct 3, 2023
Thanks to @spiffcs and #69 for the prompt to update this
@owenrumney
Copy link
Owner

thanks - I can't push to your branch but I've used the commits and used the oasis-open URL in #71

@owenrumney owenrumney closed this Oct 3, 2023
@spiffcs
Copy link
Contributor Author

spiffcs commented Oct 3, 2023

Thanks @owenrumney - sorry for missing the follow up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants