removes the replacement of . for browse command #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or branches like fix-glob-for.js
|
👍 the fix looks good! To run your code, you could compile with |
owenthereal
added a commit
that referenced
this pull request
Mar 10, 2014
removes the replacement of . for browse command
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands now, this replacement breaks browse for branches like
fix-glob-for.jswhere it changes the path of the URL tofix-glob-for/jswhich is incorrect.This is my first
gocode contribution so I expect feedback and suggestions.Also, though I added a supporting test, I was unable to validate it since I'm still figuring out how to set all of this up. Was hoping travis would give me a hint and I could go from there.