WIP: GitHub Enterprise Support #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡ Let me know when it's ready for code review |
This was referenced Nov 8, 2013
The easiest way to support this initially seems to be adding a host parameter here. Ideally we should probably read from the Git configuration somehow. If we're going to be pushing to a corporate installation *and* GitHub proper this may be problematic.
The configuration from disk should pass the host parameter up through Octokit and use the proper API URL.
|
@johnbellone Do you need any help with this PR? |
|
I just haven't got around to finishing. If you have free time go ahead! I should be able to free up by next Monday. |
|
I wish I could. I don't have any copy of GHE to test against. Is it that only URL is different? |
|
Yeah, that's pretty much it. I just need to also have support for adding a proxy, etc. |
Closed
|
Master works with github enterprise now, and #115 makes it work slightly better. I think this PR can be closed. |
|
@calavera Hooray! Very happy to see it works! 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress.
I would like to be able to use this inside of my firm with our GitHub Enterprise appliance. In order to do that there needs to be a few changes. This pull-request will track everything necessary to get the project working!