Shrink uptermd Docker image by 5 MB, 20% #225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bases the output Docker image on
SCRATCH
instead of alpine. Alpine is a great base, but for statically linked Go apps, we don't even need that.I'm currently self-hosting using this updated image, it works identically as far as I can tell (e.g. no permission issues from the
noroot
user).Sizes were calculated as:
uptermd.tar
is ~26 MB,uptermd-new.tar
is 21 MB.The 5 MB isn't really that important when the image is already only 26 MB (as compared to some enormous Docker image people sling around), but I figured, why not?