Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply static analysis recommendations #14

Merged
merged 27 commits into from
Nov 9, 2018
Merged

Apply static analysis recommendations #14

merged 27 commits into from
Nov 9, 2018

Conversation

owenvoke
Copy link
Owner

@owenvoke owenvoke commented Nov 9, 2018

No description provided.

@owenvoke
Import functions in Wallet class
3116918
@owenvoke
Merge cascading str_replace calls
0962d42
@owenvoke
Add return type hints in Wallet class
a8b0c60
@owenvoke
Use strpos instead of substr
9f8478e
@owenvoke
Use a binary safe 'fopen' call
4602cdc
@owenvoke
Use self instead of class name for Wallet
5608b46
@owenvoke
Set inherited variable in the constructor
a89f871
@owenvoke
Move console components out of Console dir
833f97d
@owenvoke
Use single quotes where possible
8f16647
@owenvoke
Fix reference to Application class
7ec8f46
@owenvoke
Add a ArionumException class
d699c6e
@owenvoke
Update to throw the ArionumException class
90ca257
@owenvoke
Fix generic exception usage
d9d1d07
@owenvoke
Import GuzzleException class where necessary
4902660
@owenvoke
Move unit tests up a directory
4fa0fc3
@owenvoke
Add a setter for the customPeer property
0e7b2a0
@owenvoke
Optimise an if condition
5a40e70
@owenvoke
Update binary safe string comparison
d873e5c
@owenvoke
Use nullable default parameters where possible
eed386d
@owenvoke
Fix typos in some type hints
5fc3a85
@owenvoke
Add PHPDoc comment for ArionumException
216fc19
@owenvoke
Fix typo in masternode commands
a3094bc
@owenvoke
Merge branch 'develop' into feature/static-analysis
a9bd640
@owenvoke
Apply Psalm casting fixes
ffa9de9
@owenvoke
Update getDefaultCommands return type
45aa8fa
@owenvoke
Update return types to void for all commands
f18a315
@codecov
Copy link

codecov bot commented Nov 9, 2018 •
edited
Loading

Codecov Report

Merging #14 into develop will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop     #14      +/-   ##
============================================
- Coverage       2.67%   2.57%   -0.11%     
- Complexity       159     168       +9     
============================================
  Files             21      21              
  Lines            786     817      +31     
============================================
  Hits              21      21              
- Misses           765     796      +31
Impacted Files Coverage Δ Complexity Δ
src/Application.php 33.33% <ø> (ø) 7 <0> (?)
src/BaseCommand.php 25% <0%> (ø) 12 <0> (?)
src/Commands/DecryptCommand.php 0% <0%> (ø) 4 <3> (?)
src/Commands/TransactionCommand.php 0% <0%> (ø) 4 <3> (?)
src/Commands/EncryptCommand.php 0% <0%> (ø) 7 <6> (?)
src/Commands/Masternode/CreateCommand.php 0% <0%> (ø) 7 <6> (?)
src/Commands/ExportCommand.php 0% <0%> (ø) 2 <1> (?)
src/Commands/Alias/SendCommand.php 0% <0%> (ø) 9 <8> (?)
src/Commands/Masternode/ReleaseCommand.php 0% <0%> (ø) 3 <2> (?)
src/Api.php 0% <0%> (ø) 15 <5> (+4) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c612a59...0af5f79. Read the comment docs.

@owenvoke owenvoke merged commit 0af5f79 into develop Nov 9, 2018
@owenvoke owenvoke deleted the feature/static-analysis branch November 9, 2018 09:49
owenvoke added a commit that referenced this pull request Nov 15, 2018
@owenvoke
Add v2.0.0 to the CHANGELOG
4411ed7 
Closes #11, closes #12, closes #14
owenvoke added a commit that referenced this pull request Nov 15, 2018
@owenvoke
Merge tag 'v2.0.0' into develop
face32d 
Add support for custom wallet paths, and use the API wrapper

Closes #11, closes #12, closes #14

# gpg: Signature made 11/15/18 14:59:12 GMT Standard Time
# gpg:                using ECDSA key F6F9165CA58F8FD42470BDFA8F15E14C0F7BA063
# gpg: Good signature from "Owen Voke <owzie123@gmail.com>" [ultimate]
# gpg:                 aka "pxgamer <owzie123@gmail.com>" [ultimate]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver: minor type: maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@owenvoke