-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "Former" prefix for historic countries #156
Comments
Since this would touch a lot of ETL datasets, it would really make it easier to have a simple sanity checker, at least something that compared the range of values in each column in the primary key. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Removing |
@pabloarosado Hey, marking this one as "prio 3 - nice to have" for now, since we have some other correctness issues we'd like to fix first. But if at some stage you wanted to champion this, we'd be happy to help out. |
Hi @Marigold now that we have the new |
@pabloarosado had an idea to use "Former " prefix for historic countries, e.g.
USSR -> Former USSR
,Yugoslavia -> Former Yugoslavia
. Hannah and others approved it.Scope
countries_regions
table to indicate if this country is historiccountries_regions
and make sure regions grouping doesn't changepopulation
dataset works correctly after this change as it is used outside this repositoryIn case this turns out to be trickier than expected, we might do it as part of larger countries_regions refactoring.
The text was updated successfully, but these errors were encountered: