Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "Former" prefix for historic countries #156

Closed
5 tasks
Tracked by #779
Marigold opened this issue Apr 5, 2022 · 5 comments
Closed
5 tasks
Tracked by #779

Use "Former" prefix for historic countries #156

Marigold opened this issue Apr 5, 2022 · 5 comments

Comments

@Marigold
Copy link
Collaborator

Marigold commented Apr 5, 2022

@pabloarosado had an idea to use "Former " prefix for historic countries, e.g. USSR -> Former USSR, Yugoslavia -> Former Yugoslavia. Hannah and others approved it.

Scope

  • Add a column to the countries_regions table to indicate if this country is historic
  • Rename those countries in countries_regions and make sure regions grouping doesn't change
  • Make sure population dataset works correctly after this change as it is used outside this repository
  • Rename them in the grapher DB tables (entities themselves and the harmonization tables)
  • Check for countries that need renaming in harmonized ETL steps

In case this turns out to be trickier than expected, we might do it as part of larger countries_regions refactoring.

@larsyencken
Copy link
Collaborator

Since this would touch a lot of ETL datasets, it would really make it easier to have a simple sanity checker, at least something that compared the range of values in each column in the primary key.

@stale
Copy link

stale bot commented Jul 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 16, 2022
@Marigold
Copy link
Collaborator Author

Removing wontfix, I think this is still important. We're still using custom solutions such as this, but having a unified approach would be nice.

@Marigold Marigold removed the wontfix This will not be worked on label Jul 18, 2022
@larsyencken
Copy link
Collaborator

@pabloarosado Hey, marking this one as "prio 3 - nice to have" for now, since we have some other correctness issues we'd like to fix first. But if at some stage you wanted to champion this, we'd be happy to help out.

@pabloarosado
Copy link
Contributor

Hi @Marigold now that we have the new regions dataset, where we have information about historical regions, I think we don't need to impose this suffix to historical regions. So, if you agree, feel free to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants