Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Deleting files from DigitalOcean Spaces does not work #55

Closed
marcelgerber opened this issue Nov 26, 2021 · 0 comments · Fixed by #64
Closed

Bug: Deleting files from DigitalOcean Spaces does not work #55

marcelgerber opened this issue Nov 26, 2021 · 0 comments · Fixed by #64

Comments

@marcelgerber
Copy link
Member

The food_explorer dataset at one point contained a file grounut_oil.csv (with a typo in the name), which was then deleted in subsequent versions.
However, the file is not properly deleted from the DigitalOcean bucket.

Below is the output of the second run of make publish.
You can see that it correctly has DEL garden/explorers/2021/food_explorer/grounut_oil.csv, but doesn't include it in the Datasets to delete section.

owid@owid-live:~/etl$ make publish
==> Running full etl
.venv/bin/etl
Detecting which steps need rebuilding...
Running 1 steps:
1. data://garden/explorers/2021/food_explorer...
OK (149s)

==> Creating a catalog index
.venv/bin/reindex
==> Publishing the catalog
.venv/bin/publish
Datasets to sync:
- garden/explorers/2021/food_explorer
  PUT garden/explorers/2021/food_explorer/oranges.meta.json
  PUT garden/explorers/2021/food_explorer/string_beans.meta.json
  [...]
  PUT garden/explorers/2021/food_explorer/palm_fruit_oil.csv
  DEL garden/explorers/2021/food_explorer/grounut_oil.csv
  DEL garden/explorers/2021/food_explorer/grounut_oil.meta.json
Datasets to delete:
@marcelgerber marcelgerber changed the title Bug: Deleting datasets does not work Bug: Deleting files does not work Nov 26, 2021
@marcelgerber marcelgerber changed the title Bug: Deleting files does not work Bug: Deleting files from DigitalOcean Spaces does not work Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant