✨ match-variables: check validity of output_file #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonerf
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Works for me! Thanks @lucasrodes really appreciate you fixing this so quickly 💪🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command line tool
etl-match-variableshas a required input argumentoutput-file, which points to the file where the variable mapping will be saved. If this file is notJSON, the export will fail.This is currently not being checked, hence if the user of the tool was to insert an invalid value for
output-filethey will only realise at the very end (after investing time in building the variable mapping).Hence, this PR sanity checks the value of
output-fileat first.First raised in #1403