Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

✨ check for np.nan in nullable types #92

Merged
merged 2 commits into from
Jun 1, 2023
Merged

✨ check for np.nan in nullable types #92

merged 2 commits into from
Jun 1, 2023

Conversation

Marigold
Copy link
Collaborator

@Marigold Marigold commented Jun 1, 2023

We recently ran into nasty error when s.dropna() wasn't working for Float64 with np.nan. I'm fixing the root cause in ETL, this PR catches those cases in dataset.add(table).

pabloarosado
pabloarosado approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@pabloarosado pabloarosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will help catch at least some of the cases.

owid/catalog/datasets.py Outdated Show resolved Hide resolved
@Marigold Marigold merged commit 1b57e1f into master Jun 1, 2023
4 checks passed
@Marigold Marigold deleted the check-nullable-types branch June 1, 2023 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pabloarosado pabloarosado pabloarosado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Marigold @pabloarosado