Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test against pre-release versions of dependencies #171

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

BorisMuzellec
Copy link
Collaborator

Reference Issue or PRs

Closes #170

What does your PR implement? Be specific.

Following @ivirshup's suggestion, this PR adds tests against pre-release versions of pydeseq2's dependencies to the CI.

Copy link
Collaborator

@maikia maikia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not aware of the pip-flags: "--pre" but seems to be working well. What is the reasoning behind removing Python 3.11? I would prefer if we don't do it. for a reference the table of supported python versions.
Nevertheless, I approve and let you make the final decision

@BorisMuzellec
Copy link
Collaborator Author

Hi @maikia, thanks for having a look. Nice catch re python 3.11, it was not intentional. Let me add it back.

What do you think of removing support / tests for Python 3.8 though? In particular, recent releases of numpy are no longer supporting it.

@maikia
Copy link
Collaborator

maikia commented Sep 25, 2023

In general, I support removing Python 3.8. Though it should be made clear as a lot of people are still using Python 3.8. Maybe you can release a new version which does not support 3.8 while the old ones (ie this one) still does?

@BorisMuzellec BorisMuzellec merged commit 45dd9bc into main Sep 25, 2023
12 checks passed
@BorisMuzellec BorisMuzellec deleted the pre_release_tests branch September 25, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test against pre-release versions of dependencies
2 participants