BUG set normed_counts in sub_dds before recomputing genewise dispersions when refitting #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR implement? Be specific.
In
dds._refit_without_outliers
, theobsm["size_factors"]
ofsub_dds
should be the same as the original object when computing genewise dispersions.However, since version 0.4.1, the
_fit_MoM_dispersions
method (called byfit_genewise_dispersions
) first checks if anormed_counts
layer exists, and if not, runsfit_size_factors
.This caused size factors to be overwritten in
dds._refit_without_outliers
.To fix this, this PR sets the
normed_counts
layer insub_dds
before computing genewise dispersions.