BUG return output with same dimensions as input with mean disp fuction #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisMuzellec
requested review from
maikia,
arthurPignetOwkin and
mandreux-owkin
as code owners
thbcmlowk
reviewed
Mar 15, 2024
umarteauowkin
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
Fixes #251, fixes #249.
What does your PR implement? Be specific.
With
dds.uns["disp_function_type"] = "mean",dds.disp_functionreturns a single value, regardless of input shape. This PR fixes this behaviour by returning an output (repeated mean dispersion) of the same shape as in the input.Further, it refactors
DeseqDataSetto add atrend_fit_typeattribute that allows controlling how the trend curve is fitted (only"parametric"and"mean"are supported for now).A test case for
trend_fit_type = "mean"was also implemented.