Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: owlBufferUpload not implemented for managed memory buffers, host mapped buffers #39

Closed
natevm opened this issue Apr 2, 2020 · 2 comments

Comments

@natevm
Copy link
Contributor

natevm commented Apr 2, 2020

More of a feature request than an issue.

I'm trying to convert my owlDeviceBuffers into owlManagedMemoryBuffers, to enable device-side memory oversubscription. However, since owlBufferUpload isn't implemented for owlManagedMemoryBuffers, I need to refactor my code to instead memcpy into a pointer through owlBufferGetPointer(). owlBufferGetPointer then wants me to specify which device the buffer belongs to, but managed memory and host memory don't belong to a particular device, so this is somewhat confusing.

If owl were to implement the same owlBufferUpload API for both managed memory buffers and host mapped buffers, it would be easier to refactor code to make the switch back and forth.

@natevm natevm changed the title owlBufferUpload not implemented for managed memory buffers, host mapped buffers Feature request: owlBufferUpload not implemented for managed memory buffers, host mapped buffers Apr 3, 2020
@ingowald
Copy link
Contributor

Is this issue still active? According to the code I just looked at upload is implemented for both host-pinned an managed mem buffers; the only functionality that's not "trivially" implemented is buffer upload to a specific device ID, because for host-pinned and managed memory buffers this doesn't really make sense. (though even for those there are proper and error messages in that case
)

@natevm
Copy link
Contributor Author

natevm commented Sep 13, 2021

Yeah, I think this has since been fixed. I can close the issue.

@natevm natevm closed this as completed Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants