[WIP] Restructure eigen installation using upstream as a base #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps only what was missing (at least in my version of eigen3 -- ubuntu 18.04) from the upstream library and reorganises the installation process to install the libeigen.a artifact among the rest of the eigen package without obscure copies. I have tested this with owl and seems to be working. Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
|
This still needs me to create a conf-eigen and add it to the opam file, and update the remove steps. In fact, in the actual form, it will be easy to port it to jbuilder if you have no objection about it. Also I imagine that you have kept the whole eigen in the subfolder to have optimised compilation flags, in that case I should probably put it all back. |
|
My apologies for the delay. Awesome PR! Thank you Marcello 👍 |
|
Porting to jbuilder would be awesome, I definitely have no objection with it. Actually, I tried porting to jbuilder before, didn't end up well because some issues of compiling c++ code. If you can manage, then really great! |
ryanrhymes
added a commit
that referenced
this pull request
Aug 30, 2018
This reverts commit 6322e23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps only what was missing (at least in my version
of eigen3 -- ubuntu 18.04) from the upstream library and
reorganises the installation process to install the
libeigen.a artifact among the rest of the eigen package
without obscure copies. I have tested this with owl and
seems to be working.
Signed-off-by: Marcello Seri marcello.seri@gmail.com