-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homebrew openblas location #138
Comments
I think the best way is the path is correctly set during compiling and linking so that info can be saved in owl's lib (if my understanding about how ocaml build system works is correct), I previously made a conf-openblas lib but that does not work very well itself so I am not really using it atm. Yes, owl's compiling and linking is still a bit broken, need to find some time to fix it. |
I created PR: #139 |
I'm not having any trouble on MacOS with the current jbuid files in the current master, fwiw. For a while I was modifying src/owl/ jbuild by hand, but the file has changed since then. @mor1 are you using the opam version or compiling from the repo? Maybe the problem has been fixed but the fix hasn't yet made it into an opam release? Then again @vietlq needed to fix something, in #139, so there may be variation in problems with finding libs on MacOS. |
@mars0i I used OPAM to install Owl and got the error. FYI, on Travis build for Owl on Ubuntu Trusty has been failing for quite some time as it couldn't find the library |
My earlier comment was incorrect. I was in fact using a src/owl/jbuilder file that I had modified, but I didn't realize that. The modification was the addition of |
(FWIW I was relying only on released things in OPAM and Homebrew.) |
@mor1, yes, that seems reasonable, but at the moment Owl has some issues with building on MacOS. Owl is great, but it's a work in progress in some respects. @vietlq's pull request that's been recently submitted that should fix it. At least that fix works on my systems. As a temporary fix, one needs to add
after
in src/owl/jbuild, as indicated here (no reason that you should have known that). It looks like the only way to do this is to download the source, because even if you modify the source under .opam, However, once you get Owl to build using |
Thanks all. As I don't use |
@vietlq Thank you very much for fixing this, and my apologies for the delay. As @mars0i said, there is still a lot of work to do to improve Owl's building and deployment. I recently fixed the docker image to make sure it reflects the most up-to-date master branch, but the Travis CI is still broken, and I really appreciate if anyone can fix it. @mor1 yes, with homebrew, this jbuild should be fine. |
Perhaps there could be an environment variable such as
This broke for me with the following output:
How do I tell conf-openblas.0.2.1 where to find openblas? Cheers, |
for me I initially get:
from
after exporting that:
I'm guessing this is because I'm on an M1 mac I was previously able to install successfully in another project on this laptop but I forget if/what I did for it to work, not sure what might have changed (not sure if this info is relevant: https://stackoverflow.com/a/66333485/202168 and https://stackoverflow.com/a/69926065/202168 ...FWIW I have clang 14.0.0 and |
For apple arm you need #625 (comment) |
LOL thanks, I can see in the comments that 'old me' from 6 weeks ago had previously found that solution and then forgot about it 🤦♂️ |
maybe it's worth looking at how the lacaml and gsl ocaml bindings handle this. i got those to install on my intel mac by setting environment variables that these bindings use for obtaining the lib locations, called |
Installed successfully by first finding the location of
Then, I did what the error suggested and exported the path I got from the above in the environment
I then opened a new terminal window and reran |
Installing owl.0.3.0 just now, I'm told
brew remove openblas ; brew install openblas
then gives me notice...which would explain why then
opam install owl
failed with# ld: library not found for -lopenblas
.brew link --force openblas
seemed to fix things. (But may break things for other packages that depend on the Apple provided BLAS and LAPACK libs I guess.)The text was updated successfully, but these errors were encountered: