Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lib path for macOS to find openblas #139

Merged
merged 1 commit into from
Dec 24, 2017
Merged

Added lib path for macOS to find openblas #139

merged 1 commit into from
Dec 24, 2017

Conversation

vietlq
Copy link
Contributor

@vietlq vietlq commented Dec 16, 2017

Added lib path for macOS to find openblas.

This shouldn't affect other OS that already find openblas. macOS doesn't have libopenblas.[a|dylib] in /usr/local/lib or /usr/lib.

@vietlq
Copy link
Contributor Author

vietlq commented Dec 18, 2017

Found another missing library -lgfortran for Ubuntu Trusty:

# (cd _build/default && /home/travis/.opam/4.04.2/bin/ocamlmklib.opt -g -o src/owl/owl_stubs src/owl/owl_dense_common_c.o src/owl/owl_dense_common_vec_cmp.o src/owl/owl_dense_common_vec_map.o src/owl/owl_dense_common_vec_fold.o src/owl/owl_cblas_generated_stub.o src/owl/owl_lapacke_generated_stub.o -L/usr/local/lib/gcc/7 -L/usr/local/opt/openblas/lib -lopenblas -lgfortran -lm)

# /usr/bin/ld: cannot find -lgfortran

# collect2: error: ld returned 1 exit status

@tachukao
Copy link
Member

tachukao commented Dec 20, 2017

@vietlq jbuilder finishes building owl without any errors after I added in -L/usr/local/opt/openblas/lib. However, when I try to use it in utop, it complains

Cannot load required shared library dllowl_stubs.
Reason: dllowl_stubs.so: dlopen(dllowl_stubs.so, 138): image not found.

any ideas? thanks!

UPDATE:
works in utop now that I moved dllowl_stubs.so from ~/.opam/.../lib/stubslibs/ to ~/.opam/.../lib/stublibs/

@ryanrhymes ryanrhymes merged commit ffe979c into owlbarn:master Dec 24, 2017
@ryanrhymes
Copy link
Member

@vietlq Thanks again for fixing this 💯

@tachukao yes, the extra s in stubslibs relates to an issue in opam which has been fixed since opam 2.0 beta 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants