Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual Merge: 2+ player support for gc/n64 #46

Closed
Ownasaurus opened this issue Feb 2, 2021 · 3 comments
Closed

Manual Merge: 2+ player support for gc/n64 #46

Ownasaurus opened this issue Feb 2, 2021 · 3 comments

Comments

@Ownasaurus
Copy link
Owner

I would like to manually merge https://github.com/sauraen/TAStm32/tree/FourPlayerGCN64. It is probably easier to manually merge in the changes rather than do a proper pull request due to the deviation over time. Careful consideration should be made as to whether or not players 3 and 4 can be supported in the upcoming v4 hardware changes. Since for vis boards, voltage is an output, but for N64, it would not be. Either way, 2-player support should be easy peasy! Just gotta do it. Since it's not going to be a formal pull request, need to make sure to update README.md to properly credit Sauraen
@Ownasaurus
Copy link
Owner Author

Began to resolve this issue in: https://github.com/Ownasaurus/TAStm32/tree/n64-2p . Decided to make it only 2p for now.

@Ownasaurus
Copy link
Owner Author

Confirmed NES and SNES are still functioning correctly

@Ownasaurus Ownasaurus mentioned this issue Feb 27, 2021
Merged
@Ownasaurus
Copy link
Owner Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ownasaurus