Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to disable join messages in chat #1582

Closed
henning-schild opened this issue Dec 9, 2021 · 6 comments · Fixed by #1743
Closed

add an option to disable join messages in chat #1582

henning-schild opened this issue Dec 9, 2021 · 6 comments · Fixed by #1743
Assignees
Labels
admin Issues related to the Admin portion chat Issues dealing with the web chat client and server good first issue Good for newcomers

Comments

@henning-schild
Copy link

Just hosted an even with v0.0.10 with hundreds of attendees and quite a bit of fluctuation. That all went great! While the name changing notifications are really needed to keep track of who asked a question before changing their name ... the join/leave causes a lot of noise which disturbs the chat flow and makes the chat hard to follow.

It would be nice if such notifications could be disabled in the admin gui.

@gabek gabek changed the title add an option to disable join/leave messages in chat add an option to disable join messages in chat Dec 9, 2021
@gabek
Copy link
Member

gabek commented Dec 9, 2021

I'm glad it went well! I've been telling people just to hide these messages via CSS, and that's still the solution in the short term. But enough people have asked for the ability to turn off join messages that it seems like it's something that should probably be added.

Renamed the issue to reflect that there are no leave messages.

@gabek gabek added admin Issues related to the Admin portion chat Issues dealing with the web chat client and server good first issue Good for newcomers labels Dec 9, 2021
@gabek
Copy link
Member

gabek commented Dec 9, 2021

If anybody wants to look at this https://github.com/owncast/owncast/blob/develop/core/chat/server.go#L94 is where to start.

GitHub
Take control over your live stream video by running it yourself. Streaming + chat out of the box. - owncast/server.go at develop · owncast/owncast

@nebunez nebunez self-assigned this Jan 4, 2022
@nebunez
Copy link
Contributor

nebunez commented Jan 4, 2022

I'm happy to take this one, as this is something I want myself. I believe hiding these messages with CSS causes extra messages to be hidden --see #1627

@cincodenada
Copy link

cincodenada commented Jan 12, 2022

One thing that I've seen on some IRC clients that I think is useful is that a bunch of joins in a row (without messages in between) are collapsed/summarized as "user1, user2, and 5 other users joined" or some such, with the most recent joins being the ones called out in the text. I think that's a good in between option to consider!

Edit: To give a concrete example (and implementation, albeit in a totally different context), the irssi-reolving-door plugin is where I'm mainly familiar with this.

I'll try to do an example of what this might look like in our context, but don't hold me to it if I screw something up 😅

somekinda-ocelot joined
"Hey everybody, this is an actual message"
other-funky-name joined
grumpy-clump joined
other-funky-name is now known as jonny5
garbanzo-keyboard joined
sparrow-knuckles joined
somekinda-ocelot is now known as someguy

I believe Would become something like:

somekinda-ocelot joined
"Hey everybody, this is an actual message"
sparrow-knuckles and three others joined [maybe a mouseover shows "jonny5, garbanzo-keyboard, grumpy-clump"]
somekinda-ocelot is now known as someguy

@gabek
Copy link
Member

gabek commented Feb 11, 2022

@nebunez Are you still planning on looking at this? I'm starting on the v0.0.12 items and I want to know if it's something I should take care of.

@henning-schild
Copy link
Author

@gabek Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Issues related to the Admin portion chat Issues dealing with the web chat client and server good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants