Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Restructure #16

Closed
graywolf336 opened this issue Jun 19, 2020 · 2 comments · Fixed by #18
Closed

Project Restructure #16

graywolf336 opened this issue Jun 19, 2020 · 2 comments · Fixed by #18

Comments

@graywolf336
Copy link
Contributor

What would be your thoughts on the following project structure:

├── config 
│   └── config.go
├── controllers (http controllers)
│   ├── chat.go
│   └── static.go
├── core (the logic lives here)
│   ├── ffmpeg/
│   │   ├── offline.go
│   │   └── start.go
│   ├── rtmp/
│   │   ├── handler.go
│   │   └── server.go
│   ├── storage/ (implementations)
│   │   ├── ipfs.go
│   │   └── aws.go
│   ├── storage.go (interface)
│   ├── core.go
│   ├── stats.go
├── models (definitions for how data will be handled)
│   ├── stat.go
│   ├── server.go
│   └── etc.go
├── utils
│   └── utils.go
├── static (stays the same)
│   └── logo.png (etc)
├── webroot (stays the same)
│   ├── img/
│   ├── js/
│   ├── static/
│   ├── styles/
│   ├── vendor/
│   └── index.html
├── go.mod
├── go.sum
├── main.go
├── config.sample.yaml
├── README.md
├── Dockerfile
└── .gitignore

This is a massive difference from the current structure of the project and I am willing to start the PR to move it and work on the restructuring. Curious to hear your thoughts

@gabek
Copy link
Member

gabek commented Jun 19, 2020

Music to my ears! I think this is great! Currently it's been in the typical "this is a new project and I don't know what we need, so no use prematurely trying to organize it", but I think it's past that now and it makes sense to add structure to it. I think the layout you proposed makes as much sense as any. I really appreciate the thought you put into it. Go for it!

@graywolf336
Copy link
Contributor Author

Awesome!! I'll get to work on it and maybe have something by Monday, unless I get enough time to work on it this evening :)

@gabek gabek closed this as completed in #18 Jun 23, 2020
gabek pushed a commit that referenced this issue Apr 26, 2022
Add random streamkey generation and copy key
xarantolus pushed a commit to xarantolus/owncast that referenced this issue Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants