Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc chat updates #26

Closed
4 tasks done
gabek opened this issue Jun 23, 2020 · 7 comments
Closed
4 tasks done

Misc chat updates #26

gabek opened this issue Jun 23, 2020 · 7 comments
Assignees

Comments

@gabek
Copy link
Member

gabek commented Jun 23, 2020

While in the future I'm sure there will be a major update, I wanted to add an issue for short term things to add.

@graywolf336
Copy link
Contributor

Updated the list and added persist chat

@gabek
Copy link
Member Author

gabek commented Jun 25, 2020

Disable chat after stream ends.

With 8878ca1 the web frontend now knows the time the stream disconnected. We can add a grace period so N minutes after a disconnect is when the chat is locked down. What should that value be? 5 minutes comes to mind as a middle ground. Anything longer than that and the streamer probably isn't coming back, but I could see somebody dropping off for a few minutes for whatever reason. Rebooting their computer, changing streaming settings, etc. What do you think?

@gabek
Copy link
Member Author

gabek commented Jun 25, 2020

Persist chat

How far back should we persist?

We were earlier talking about Boltdb, but it might make more sense to use SQLite so we can efficiently query against timestamps and use it more as live storage than just on-disk source of restoring an array of messages.

@gingervitis gingervitis self-assigned this Jul 12, 2020
@gingervitis
Copy link
Collaborator

I'll look into implementing checkbox 3 - with tis logic
When status.online has flipped to false; then disable chat after X time.

@gingervitis
Copy link
Collaborator

Re: persisting chat - include timestamps with each message.

gabek added a commit that referenced this issue Jul 12, 2020
@gabek
Copy link
Member Author

gabek commented Jul 12, 2020

@graywolf336 Curious about your thoughts on using an ORM like https://github.com/go-gorm/gorm for working with the chat persistence, have you ever used it or anything similar? I've only used the database/sql stuff, but I'm curious if there's any niceties around an ORM or if it's worth it for something simple like this.

gabek added a commit that referenced this issue Jul 12, 2020
gabek added a commit that referenced this issue Jul 12, 2020
gabek added a commit that referenced this issue Jul 12, 2020
@gabek
Copy link
Member Author

gabek commented Jul 12, 2020

Added basic chat persistence.

@gabek gabek added this to the v0.0.1 First actual release milestone Jul 14, 2020
@gabek gabek closed this as completed Jul 16, 2020
gabek added a commit that referenced this issue Apr 26, 2022
…ugin-react-7.22.0

Bump eslint-plugin-react from 7.21.2 to 7.22.0
xarantolus pushed a commit to xarantolus/owncast that referenced this issue Feb 14, 2023
* Merge contributors from all projects. Stop needless commits. Closes owncast#13

* Update dynamic content

Co-authored-by: Owncast <owncast@owncast.online>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants