Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate frontend & backend configs #30

Closed
gabek opened this issue Jun 25, 2020 · 7 comments
Closed

Consolidate frontend & backend configs #30

gabek opened this issue Jun 25, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@gabek
Copy link
Member

gabek commented Jun 25, 2020

I think it would be nice to have a single place to make changes and not have to specify that you're talking about the backend config vs. the frontend config, especially in initial setup and in documentation.

Since we're already pulling in config.json on the frontend asynchronously we could simply create a /config endpoint that returns the same values config.json does based on the values in config.yaml and point there instead.

No rush to do this, since having a standalone frontend config right now allows faster iteration on the web UI, but would this be a positive change eventually? What are your thoughts @gingervitis ?

@gabek gabek added the enhancement New feature or request label Jun 25, 2020
@gingervitis
Copy link
Collaborator

After clarifying with @gabek how this would work, I think it currently makes sense to put this all the info into one file. I like the idea of having set restricted types of these fields which would allow us to have a more consistent and controllable look and feel across Owncast instances.

And in this case, if we ever need to add a new configurable frontend field, all instances would need to be updated to use it because the config structure has changed and the frontend markup will have most likely changed.

@gingervitis
Copy link
Collaborator

..On that note, can I make a request to add a couple fields to the config? 😁

  • allow for different logo image sizes,
logo: {
  small: "logo64x64.png",
  large: "logo256x256.png",
},
...
  • string to the "extra" static info content.md field.. Perhaps something along the lines of:
{
  ...
  extraUserInfoFileName: "/static/content-example.md",
}

(Sorry I can't think of a better name for that right now)

@gabek
Copy link
Member Author

gabek commented Jun 28, 2020

On it!

@gabek gabek self-assigned this Jun 28, 2020
@gabek gabek closed this as completed in 73b6937 Jun 28, 2020
gabek added a commit that referenced this issue Jun 28, 2020
@gabek
Copy link
Member Author

gabek commented Jun 28, 2020

@graywolf336 Heads up, this is changed in master, so now both frontend and backend has a single config location.

@graywolf336
Copy link
Contributor

Awesome!! 🎉

@gingervitis
Copy link
Collaborator

@gabek One more request, regarding the social list in the config-
Can you make that list an array, that would end up looking like this:
[
{platform: "facebook", url: "http.."},
{platform: "instagram", url: "http.."}
]

This will let users order their social acts by priority.

@gingervitis gingervitis reopened this Jun 30, 2020
@gabek gabek closed this as completed in 85cec76 Jul 1, 2020
@gabek
Copy link
Member Author

gabek commented Jul 1, 2020

Ok, it now looks like this:

"socialHandles": [
{
"platform": "twitter",
"url": "http://twitter.com/owncast"
},
{
"platform": "instagram",
"url": "http://instagram.biz/owncast"
},
{
"platform": "facebook",
"url": "http://facebook.gov/owncast"
},
{
"platform": "tiktok",
"url": "http://tiktok.cn/owncast"
},
{
"platform": "soundcloud",
"url": "http://soundcloud.com/owncast"
}

gabek added a commit that referenced this issue Apr 26, 2022
xarantolus pushed a commit to xarantolus/owncast that referenced this issue Feb 14, 2023
xarantolus pushed a commit to xarantolus/owncast that referenced this issue Feb 14, 2023
* 📝 add initial version of blogpost for 0.0.5

* Update owncast-0.0.5.md

* Update dynamic content

* Add digitalocean spaces documentation (owncast#30)

* Fix link

* Update release notes

* Add 0.0.5 api docs

* Point to 0.0.5 link

* Add more changelog items

* Point installer at 0.0.5

Co-authored-by: Owncast <owncast@owncast.online>
Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com>
Co-authored-by: Gabe Kangas <gabek@real-ity.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants