Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat: Refactor initial population of chat history to use API #47

Closed
gabek opened this issue Jul 11, 2020 · 3 comments · Fixed by #67
Closed

Chat: Refactor initial population of chat history to use API #47

gabek opened this issue Jul 11, 2020 · 3 comments · Fixed by #67
Assignees
@gabek
Labels
enhancement New feature or request
Milestone
v0.0.1 First actu...

Comments

@gabek
Copy link
Member

gabek commented Jul 11, 2020

@graywolf336 Added a /chat endpoint, so I think it makes sense to use that to populate the chat history instead of funneling the entire history through the socket every time somebody connects.
@gabek gabek added the enhancement New feature or request label Jul 11, 2020
@gabek
Copy link
Member Author

gabek commented Jul 14, 2020

I was thinking maybe we should move it, but really I have no solid reasons why except "why flood the socket with old messages if we don't need to". But I'm not sure what I'm concerned about. Let's just keep it as it is unless there's a reason to change it.

@gabek gabek closed this as completed Jul 14, 2020
@gabek gabek reopened this Jul 16, 2020
@gabek gabek added this to the v0.0.1 First actual release milestone Jul 16, 2020
@gabek
Copy link
Member Author

gabek commented Jul 16, 2020

Was doing some load testing on the web socket and found that after a backlog of a certain size the websocket seems to stop passing stuff through. So I think using the GET /chat endpoint for the initial backlog makes sense.

@gabek
Copy link
Member Author

gabek commented Jul 16, 2020

Going to wait for #56 to go in so I don't step on the toes of any Javascript changes.

gabek added a commit that referenced this issue Jul 16, 2020
@gabek
Limit the backlog of chat messages to recent messages. For #47
a277012
gabek added a commit that referenced this issue Jul 17, 2020
@gabek
Use the /chat endpoint for bulk chat history population instead of we…
ff1a3e0 
…bsocket. For #47
@gabek gabek assigned gingervitis and gabek and unassigned gingervitis Jul 17, 2020
@gabek gabek linked a pull request Jul 17, 2020 that will close this issue
Use endpoint for chat history instead of websocket #67
Merged
@gabek gabek closed this as completed in #67 Jul 19, 2020
gabek added a commit that referenced this issue Jul 19, 2020
@gabek
Use endpoint for chat history instead of websocket (#67)
2855027 
* Change placeholder when chat is disabled

* Use the /chat endpoint for bulk chat history population instead of websocket. For #47

* Force LiveUI/seek bar during live to show. Closes #11.

* Change pulling chat history into app.js

* Force new messages to have visability = true
xarantolus pushed a commit to xarantolus/owncast that referenced this issue Feb 14, 2023
@gabek
Merge pull request owncast#47 from owncast/imgbot
5a340ff 
[ImgBot] Optimize images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabek gabek

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.0.1 First actual release
Development

Successfully merging a pull request may close this issue.

Use endpoint for chat history instead of websocket owncast/owncast
2 participants
@gabek @gingervitis