Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add previous testRunner jasmine2, add ws dependency explicitly #3784

Conversation

mahmed2000
Copy link
Contributor

  • v27 changed the default testRunner from jest-jasmine2 to jest-circus. v28 moved jest-jasmine2 to its own module.
  • v28 also removed jest-environment-jsdom from the jest deps, which is why ws was even being installed. v8 ws has breaking changes as well, websocket is just not used.

https://jestjs.io/blog/2020/05/05/jest-26

Not including the package-lock since my npm install keeps shuffling things around for no reason.

@gabek
Copy link
Member

gabek commented Jun 14, 2024

Great find, thanks for fixing this up!

@gabek gabek merged commit 954b295 into owncast:dependabot/npm_and_yarn/test/automated/api/multi-2e9cc7d425 Jun 14, 2024
11 checks passed
gabek pushed a commit that referenced this pull request Jun 14, 2024
* Bump braces and jest in /test/automated/api

Bumps [braces](https://github.com/micromatch/braces) to 3.0.3 and updates ancestor dependency [jest](https://github.com/jestjs/jest/tree/HEAD/packages/jest). These dependencies need to be updated together.


Updates `braces` from 3.0.2 to 3.0.3
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

Updates `jest` from 26.6.3 to 29.7.0
- [Release notes](https://github.com/jestjs/jest/releases)
- [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/jestjs/jest/commits/v29.7.0/packages/jest)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
- dependency-name: jest
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add previous testRunner jasmine2, add ws dependency explicitly (#3784)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mahmed2000 <mahmad2000@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants