adding unhosted_apps v1.0.6 #47
Conversation
…hecks, improved controller object
| if(count($apps)) { | ||
| $token = $apps[0]['access_token']; | ||
| } else { | ||
| $token = base64_encode(openssl_random_pseudo_bytes(40)); |
There was a problem hiding this comment.
This would create a hard dependency on openssl support in php, using OC_Util::generate_random_bytes provides a fallback for it.
…into unhosted-apps
…logged in at least once
|
most of it should work now |
|
only thing is the unit tests assume the existence of a user called 'dummy' which exists on my instance but will fail on other instances. any pointer to documentation about how to set up proper dummy users inside unit tests greatly appreciated! the existing docs and pointers did not really explain it for me. |
|
You can add a dummy user backend that has the user you test with from the top of my head: $backend=new OC_User_Dummy();
$backend->createUser('dummy','dummy');
OC_User::clearBackends();
OC_User::useBackend($backend)although this should probably be done globally for all tests |
|
@icewind1991 that helped, thanks! it still needs the folder /var/www/data/dummy to exist for the tests to pass, but not the actual 'dummy' user. |
|
Just curious: what does this do? How is it related to the remotestorage app? |
|
@michielbdejong it looks like you've been left in the dark for quite a while... What is the status of this app? |
|
Can one of the admins verify this patch? |
|
@owncloud-bot this is okay to test |
|
Re @zimba12 this is the successor of the 'remoteStorage compatibility' app. It adds an 'Unhosted apps' pane from where you can launch unhosted web apps. So it is now more like an unhosted web apps launch pad (storage-first scenario, see http://lanyrd.com/2012/unhosted/sygwp/ ). Re @tanghus no worries! It would be nice if you could add this "unhosted_apps" directory to your apps repo and remove the "remoteStorage" directory that it deprecates. |
|
@michielbdejong A lot of irrelevant files - 697 ;) - in this PR. Could you make a fresh pull request with only the app itself. I'm guessing rebasing to master would be a hassle /cc @DeepDiver1975 |
|
ok, will close this one and create a new one. thanks! will also improve it a bit while i'm at it, because i just realized it is still probably very hard to use for anybody other than me... |
adding the 'unhosted-apps' branch to work in.